Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzurePipeline: Add build test to basetools CI #29

Open
wants to merge 2 commits into
base: newmaster
Choose a base branch
from

Conversation

BobCF
Copy link
Member

@BobCF BobCF commented Feb 7, 2022

Signed-off-by: Bob Feng [email protected]

steps:
- template: templates/platform-build-run-steps.yml
parameters:
tool_chain_tag: GCC5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "GCC" now, since the "GCC5" toolchain is deprecated.

- job: Platform_CI
variables:
package: 'OvmfPkg'
vm_image: 'ubuntu-18.04'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 18.04 is really old now. Could we use something newer like 22.04 or 24.04?

jobs:
- template: templates/pr-gate-build-job.yml
parameters:
tool_chain_tag: 'GCC5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this should be "GCC".

parameters:
tool_chain_tag: 'GCC5'
vm_image: 'ubuntu-latest'
arch_list: "IA32,X64,ARM,AARCH64,RISCV64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want loonsong too?


- task: UsePythonVersion@0
inputs:
versionSpec: "3.8.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.8 is pretty old now. Do we want to use something newer?

## CI Build Status
| Host Type & Toolchain | Build Status |
| --------------------- | ------------ |
| Windows_VS2019_ | [![Build Status](https://dev.azure.com/bobcfeng/edk2-bob/_apis/build/status/BobCF.edk2-basetools-vs2019-build?repoName=BobCF%2Fedk2-basetools&branchName=newmaster)](https://dev.azure.com/bobcfeng/edk2-bob/_build/latest?definitionId=9&repoName=BobCF%2Fedk2-basetools&branchName=newmaster) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be under the tianocore project instead of bobcfeng?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants